yoga: merge upstream unmaintained/yoga #980
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markgoddard
commented
Mar 8, 2024
markgoddard
commented
- kayobe-env: Unstick KOLLA_SOURCE_PATH and KOLLA_VENV_PATH
- Synchronise with kayobe stable/yoga
- Update .gitreview for unmaintained/yoga
The kayobe-env script does not update the KOLLA_SOURCE_PATH and KOLLA_VENV_PATH variables if they are already set. This can lead to dangerous and difficult to diagnose issues where Kayobe uses a different version of Kolla Ansible than expected. This change updates these variables each time the kayobe-env script is sourced. Change-Id: I3b4b0b611750b9c7846ff5f74554aee2f14939e4 Closes-Bug: #2036711 (cherry picked from commit 651b8be)
Synchronise with kayobe @ 32b12be953d0c2f60970a95b82d0ebf846d0f86f. Change-Id: Ib4b75c084820f16ce245c1e1c50f10ccb2083537
Change-Id: Ibd47c684580d35f58b0b715eab2e5110d17bb69a
Alex-Welsh
reviewed
Mar 8, 2024
Alex-Welsh
previously approved these changes
Mar 11, 2024
markgoddard
commented
Mar 11, 2024
There was a problem hiding this comment.
Test container build job looks ok: https://github.com/stackhpc/stackhpc-kayobe-config/actions/runs/8236257980/job/22522255075
Alex-Welsh
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.