Support filtering of package repositories #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the full workflows can take a long time, which may be undesirable when we want to get changes only for a small number of package repositories (e.g. for a security or bug fix release). This change adds the ability to specify a filter to apply to the list of package repositories in the various playbooks. The filter is also exposed in the Github actions workflows.
jovial
reviewed
Aug 30, 2022
| ansible-playbook -i ansible/inventory \ | ||
| ansible/test-pulp-repo-version-query.yml \ | ||
| ansible/test-kayobe-repo-version-generate.yml \ | ||
| -e deb_package_repo_filter="'$FILTER'" \ |
There was a problem hiding this comment.
Does something swallow the single quotes? Otherwise, I'd expect the variable not to be interpreted 🤔
There was a problem hiding this comment.
Seems not
foo=bar
echo "'$foo'"
'bar'
There was a problem hiding this comment.
Didn't know that! Found the table in: https://stackoverflow.com/a/42082956 useful.
jovial
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the full workflows can take a long time, which may be
undesirable when we want to get changes only for a small number of
package repositories (e.g. for a security or bug fix release).
This change adds the ability to specify a filter to apply to the list of
package repositories in the various playbooks. The filter is also
exposed in the Github actions workflows.