-
Notifications
You must be signed in to change notification settings - Fork 1
Fix base path of Source type repos #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @seunghun1ee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where the base paths for several Rocky Linux source repositories (versions 8.10 and 9.6) were incorrectly configured. The change updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the base paths for several Rocky Linux source repositories. The change from source/os/
to source/tree/
aligns with the directory structure of the upstream mirrors, resolving an issue that would prevent repository synchronization. The changes are accurate and necessary. I've added one suggestion regarding the structure of the configuration file to improve long-term maintainability by reducing repetition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, matches original PR and upstream repos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EPEL source repositories use 8/Everything/source/tree/
and 9/Everything/source/tree/
On upstream source, their base path ends with ``source/tree/`` instead of ``source/os/``
5ee7d27
to
1c4a1d2
Compare
Test is running at https://github.com/stackhpc/stackhpc-release-train/actions/runs/18158888504 |
On upstream source, their base path ends with
source/tree/
instead ofsource/os/