Skip to content

Conversation

seunghun1ee
Copy link
Member

On upstream source, their base path ends with source/tree/ instead of source/os/

@seunghun1ee seunghun1ee self-assigned this Sep 25, 2025
@seunghun1ee seunghun1ee requested a review from a team as a code owner September 25, 2025 15:46
Copy link

Summary of Changes

Hello @seunghun1ee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where the base paths for several Rocky Linux source repositories (versions 8.10 and 9.6) were incorrectly configured. The change updates the base_path entries in the Ansible inventory to reflect the correct upstream path structure, ensuring that source packages can be located and synchronized properly. This fix improves the reliability of source package management for these specific Rocky Linux distributions.

Highlights

  • Rocky Linux 8.10 Source Repositories: Corrected the base_path for Rocky Linux 8.10 AppStream, BaseOS, and Extras source repositories, changing the suffix from source/os/ to source/tree/ to match upstream.
  • Rocky Linux 9.6 Source Repositories: Updated the base_path for Rocky Linux 9.6 AppStream, BaseOS, Extras, and CRB source repositories, adjusting the suffix from source/os/ to source/tree/ for accurate source retrieval.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the base paths for several Rocky Linux source repositories. The change from source/os/ to source/tree/ aligns with the directory structure of the upstream mirrors, resolving an issue that would prevent repository synchronization. The changes are accurate and necessary. I've added one suggestion regarding the structure of the configuration file to improve long-term maintainability by reducing repetition.

sjpb
sjpb previously approved these changes Sep 25, 2025
Copy link
Contributor

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, matches original PR and upstream repos

Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EPEL source repositories use 8/Everything/source/tree/ and 9/Everything/source/tree/

On upstream source, their base path ends with ``source/tree/`` instead
of ``source/os/``
@seunghun1ee
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants