-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add Confluence integration with configurable parameters for doc… #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ault max pages limit in document upload
…plate into chore/adminfrontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Confluence integration to the document upload system, updates related UI components, adjusts backend API calls, and refreshes localization and submodule versions.
- Define and pass a new
ConfluenceConfig
from frontend to backend viaDocumentAPI.loadConfluence
. - Enhance the upload UI with Confluence-specific input fields and adjust container heights.
- Change file upload endpoint and form-data key, update localization text, and bump submodules and dev configs.
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
rag-infrastructure | Updated submodule commit |
rag-core-library | Updated submodule commit |
frontend/libs/i18n/admin/en.json | Refined confluenceLoadTitle text |
frontend/libs/admin-app/feature-document/DocumentUploadContainer.vue | Added Confluence config inputs and adjusted heights |
frontend/libs/admin-app/data-access/document.api.ts | Introduced ConfluenceConfig and modified API calls |
frontend/libs/admin-app/data-access/+state/documents.store.ts | Updated store to accept ConfluenceConfig |
conftest.py | Added test path setup for backend and libraries |
Tiltfile | Enabled Minio feature flag |
.vscode/settings.json | Configured Python test and path settings |
.vscode/launch.json | Added Pytest debug launch configuration |
Comments suppressed due to low confidence (1)
frontend/libs/admin-app/data-access/+state/documents.store.ts:8
- The store ID 'chat' is misleading in a documents store; consider renaming to 'documents' or 'documentsStore' for clarity.
export const useDocumentsStore = defineStore('chat', () => {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…plate into chore/adminfrontend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…#19) * fix: update project title from "RAG SIT x Stackit" to "STACKIT RAG" across multiple files * fix: remove unnecessary condition in sitemap loader parameter processing
This pull request introduces significant updates to the document upload system, particularly adding support for Confluence integration. The changes include new configuration options for Confluence, updates to the backend API payloads, UI enhancements, and dependency updates. Below are the most important changes grouped by theme:
Confluence Integration:
ConfluenceConfig
interface to define configuration parameters for Confluence, includingspaceKey
,token
,url
,maxPages
, andname
, indocument.api.ts
.loadConfluence
method inDocumentAPI
to accept aConfluenceConfig
object and send it as a payload to the backend with required query parameters.useDocumentsStore
to pass aConfluenceConfig
object to theloadConfluence
method.UI Enhancements for Confluence:
DocumentUploadContainer.vue
for Confluence configuration, including URL, name, space key, token, and max pages.Backend API Adjustments:
/upload_documents
to/upload_file
and corrected the form data key frombody
tofile
inDocumentAPI
.Localization Updates:
confluenceLoadTitle
text in the English localization file to provide a clearer description.Submodule Updates:
rag-core-library
andrag-infrastructure
to new commit hashes.