Skip to content

Conversation

a-klos
Copy link
Member

@a-klos a-klos commented May 23, 2025

This pull request introduces significant updates to the document upload system, particularly adding support for Confluence integration. The changes include new configuration options for Confluence, updates to the backend API payloads, UI enhancements, and dependency updates. Below are the most important changes grouped by theme:

Confluence Integration:

  • Added a ConfluenceConfig interface to define configuration parameters for Confluence, including spaceKey, token, url, maxPages, and name, in document.api.ts.
  • Updated the loadConfluence method in DocumentAPI to accept a ConfluenceConfig object and send it as a payload to the backend with required query parameters.
  • Modified the useDocumentsStore to pass a ConfluenceConfig object to the loadConfluence method.

UI Enhancements for Confluence:

  • Added new input fields in DocumentUploadContainer.vue for Confluence configuration, including URL, name, space key, token, and max pages.
  • Updated the height of the Confluence upload area and file upload area for better usability.

Backend API Adjustments:

  • Updated the endpoint for uploading files from /upload_documents to /upload_file and corrected the form data key from body to file in DocumentAPI.

Localization Updates:

  • Updated the confluenceLoadTitle text in the English localization file to provide a clearer description.

Submodule Updates:

  • Updated submodules rag-core-library and rag-infrastructure to new commit hashes.

@a-klos a-klos marked this pull request as ready for review June 3, 2025 13:04
@huhn511 huhn511 requested a review from Copilot June 3, 2025 15:29
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Confluence integration to the document upload system, updates related UI components, adjusts backend API calls, and refreshes localization and submodule versions.

  • Define and pass a new ConfluenceConfig from frontend to backend via DocumentAPI.loadConfluence.
  • Enhance the upload UI with Confluence-specific input fields and adjust container heights.
  • Change file upload endpoint and form-data key, update localization text, and bump submodules and dev configs.

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
rag-infrastructure Updated submodule commit
rag-core-library Updated submodule commit
frontend/libs/i18n/admin/en.json Refined confluenceLoadTitle text
frontend/libs/admin-app/feature-document/DocumentUploadContainer.vue Added Confluence config inputs and adjusted heights
frontend/libs/admin-app/data-access/document.api.ts Introduced ConfluenceConfig and modified API calls
frontend/libs/admin-app/data-access/+state/documents.store.ts Updated store to accept ConfluenceConfig
conftest.py Added test path setup for backend and libraries
Tiltfile Enabled Minio feature flag
.vscode/settings.json Configured Python test and path settings
.vscode/launch.json Added Pytest debug launch configuration
Comments suppressed due to low confidence (1)

frontend/libs/admin-app/data-access/+state/documents.store.ts:8

  • The store ID 'chat' is misleading in a documents store; consider renaming to 'documents' or 'documentsStore' for clarity.
export const useDocumentsStore = defineStore('chat', () => {

@a-klos a-klos requested a review from huhn511 June 4, 2025 06:44
Copy link
Collaborator

@huhn511 huhn511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@a-klos a-klos merged commit 438d10b into main Jun 4, 2025
5 checks passed
@a-klos a-klos deleted the chore/adminfrontend branch June 4, 2025 13:47
a-klos added a commit that referenced this pull request Jul 3, 2025
a-klos added a commit that referenced this pull request Jul 3, 2025
…#19)

* fix: update project title from "RAG SIT x Stackit" to "STACKIT RAG" across multiple files

* fix: remove unnecessary condition in sitemap loader parameter processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants