Skip to content

fix: remove unused max_pages parameter from confluence loader parameters #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2025
Merged

fix: remove unused max_pages parameter from confluence loader parameters #86

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
16f5892
fix: remove unused max_pages parameter from confluence loader parameters
a-klos Sep 2, 2025
ac86c33
refactor: black
a-klos Sep 2, 2025
6646c35
fix: add logging for invalid max_pages parameter in ConfluenceExtractor
a-klos Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions libs/extractor-api-lib/src/extractor_api_lib/impl/extractors/confluence_extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
"""Module for the DefaultConfluenceExtractor class."""

import logging
from langchain_community.document_loaders import ConfluenceLoader

from extractor_api_lib.impl.types.extractor_types import ExtractorTypes
Expand All @@ -10,6 +11,8 @@
ConfluenceLangchainDocument2InformationPiece,
)

logger = logging.getLogger(__name__)


class ConfluenceExtractor(InformationExtractor):
"""Implementation of the InformationExtractor interface for confluence."""
Expand Down Expand Up @@ -54,6 +57,13 @@ async def aextract_content(
confluence_loader_parameters = {
x.key: int(x.value) if x.value.isdigit() else x.value for x in extraction_parameters.kwargs
}
if not confluence_loader_parameters.get("max_pages") or isinstance(
confluence_loader_parameters.get("max_pages"), str
):
logging.warning(
"max_pages parameter is not set or invalid discarding it. ConfluenceLoader will use default value."
)
confluence_loader_parameters.pop("max_pages")
# Drop the document_name parameter as it is not used by the ConfluenceLoader
if "document_name" in confluence_loader_parameters:
confluence_loader_parameters.pop("document_name", None)
Expand Down