Skip to content

Add support for custom IDP endpoint and client ID #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 4, 2024
Merged

Add support for custom IDP endpoint and client ID #400

merged 13 commits into from
Jul 4, 2024

Conversation

joaopalet
Copy link
Contributor

No description provided.

DiogoFerrao
DiogoFerrao reviewed Jul 4, 2024
View reviewed changes
@DiogoFerrao
Copy link
Contributor

DiogoFerrao commented Jul 4, 2024 •
edited
Loading

In general, I think we should document the process of configuring a custom IDP in a README file since its quite different from the others and could be complex.

Maybe this is the correct place to document the process, and then just refer the user to this guide in the flags, instead of cluttering the flag documentation

@joaopalet
Copy link
Contributor Author

In general, I think we should document the process of configuring a custom IDP in a README file since its quite different from the others and could be complex.

Maybe this is the correct place to document the process, and then just refer the user to this guide in the flags, instead of cluttering the flag documentation

I've added a bit more information to the flags description and have asked a colleague from the IDP for a suggestion on documentation to link.

I'm not sure the README is the right place to document these, but definitely having a page with more information about it makes sense. Maybe creating a page in the STACKIT KB?

DiogoFerrao
DiogoFerrao reviewed Jul 4, 2024
View reviewed changes
@joaopalet joaopalet enabled auto-merge (squash) July 4, 2024 14:23
@joaopalet joaopalet merged commit b799e96 into main Jul 4, 2024
@joaopalet joaopalet deleted the jp/idp-custom-endpoints branch July 4, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@DiogoFerrao DiogoFerrao DiogoFerrao approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaopalet @DiogoFerrao