fix(ske/login): use region from kubeconfig #989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubenhoenle
approved these changes
Sep 16, 2025
marceljk
approved these changes
Sep 16, 2025
This wasn't really an issue as unmarshal does prefer an "exact match but also accepting a case-insensitive match"
marceljk
force-pushed
the
fix/ske-login-multiregion
branch
from
0418d22 to
2ae33a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes retrieval of new kubeconfigs via the SKE login plugin when using the CLI in a "cross" region setup: CLI configured for
eu01but login kubeconfig for a cluster ineu02.Instead of using the CLIs
regionflag, it will now use the region as included in the login kubeconfig (.clusters.cluster.extensions.extension.region). Theregionfield will be included in all newly retrieved login kubeconfigs at the beginning of next week. But I've kept the current behavior as a fallback in case the field is missing, so this PR doesn't depend on the updated SKE-API.Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)