Skip to content

Logging and error handling improvements, bug fixes #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Sep 21, 2023
Merged

Logging and error handling improvements, bug fixes #21

merged 18 commits into from
Sep 21, 2023

Conversation

hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Sep 20, 2023 •
edited
Loading

  • Uniformed logs and diagnostics:
    • Logging and adding to diagnostics is done by the highest level function (Create/Read/Update/Delete/Import) using LogAndAddError
    • Lower-level routines' signature changed to return error instead of writing to diagnostics
    • Standardize summary and details across services
    • Removed manual adding of relevant variables to details (they're in the context, TF adds them to logs)
  • Changed validators to be closer to official implementation
  • Fix logging wrong output after wait
  • Fix Argus checking wrong diagnostics
  • Fix Resource Manager not updating state after project update
  • Fix unnecessary pointer in LogAndAddError

joaopalet
joaopalet reviewed Sep 20, 2023
View reviewed changes
joaopalet
joaopalet approved these changes Sep 21, 2023
View reviewed changes
@hcsa73 hcsa73 merged commit 4e8514d into main Sep 21, 2023
@hcsa73 hcsa73 deleted the hs/logging-error-handiling-improvements branch September 21, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joaopalet joaopalet joaopalet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcsa73 @joaopalet