-
Notifications
You must be signed in to change notification settings - Fork 35
Implement object storage credential #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
95151ec
Implement credential resource
c1861d9
Implement test
c68e115
Fix test
b37efb8
Implement data source
a834659
Implement credential acc test
e473770
Add objectstorage credential
61a9a99
Add test for enableProject
7369aee
Add readCredentials test
f5cc8d0
Removed unnecessary test case
c25e10f
Generate docs
5944d6c
Fix lint
6aed095
Fix field name
c686d82
Readd credentials group checks
381ebcf
Fix comment
e9efe0e
Fix comment
88fc146
Remove auth
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
--- | ||
# generated by https://github.com/hashicorp/terraform-plugin-docs | ||
page_title: "stackit_objectstorage_credential Data Source - stackit" | ||
subcategory: "" | ||
description: |- | ||
ObjectStorage credential data source schema. | ||
--- | ||
|
||
# stackit_objectstorage_credential (Data Source) | ||
|
||
ObjectStorage credential data source schema. | ||
|
||
|
||
|
||
<!-- schema generated by tfplugindocs --> | ||
## Schema | ||
|
||
### Required | ||
|
||
- `credential_id` (String) The credential ID. | ||
- `credentials_group_id` (String) The credential group ID. | ||
- `expiration_timestamp` (String) | ||
- `project_id` (String) STACKIT Project ID to which the credential group is associated. | ||
|
||
### Read-Only | ||
|
||
- `access_key` (String) | ||
- `id` (String) Terraform's internal resource identifier. It is structured as "`project_id`,`credentials_group_id`,`credential_id`". | ||
- `name` (String) | ||
- `secret_access_key` (String, Sensitive) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
--- | ||
# generated by https://github.com/hashicorp/terraform-plugin-docs | ||
page_title: "stackit_objectstorage_credential Resource - stackit" | ||
subcategory: "" | ||
description: |- | ||
ObjectStorage credential resource schema. | ||
--- | ||
|
||
# stackit_objectstorage_credential (Resource) | ||
|
||
ObjectStorage credential resource schema. | ||
|
||
|
||
|
||
<!-- schema generated by tfplugindocs --> | ||
## Schema | ||
|
||
### Required | ||
|
||
- `project_id` (String) STACKIT Project ID to which the credential group is associated. | ||
|
||
### Optional | ||
|
||
- `expiration_timestamp` (String) | ||
|
||
### Read-Only | ||
|
||
- `access_key` (String) | ||
- `credential_id` (String) The credential ID. | ||
- `credentials_group_id` (String) The credential group ID. | ||
- `id` (String) Terraform's internal resource identifier. It is structured as "`project_id`,`credentials_group_id`,`credential_id`". | ||
- `name` (String) | ||
- `secret_access_key` (String, Sensitive) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
149 changes: 149 additions & 0 deletions
149
stackit/internal/services/objectstorage/credential/datasource.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,149 @@ | ||
package objectstorage | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
|
||
"github.com/hashicorp/terraform-plugin-framework/datasource" | ||
"github.com/hashicorp/terraform-plugin-log/tflog" | ||
"github.com/stackitcloud/terraform-provider-stackit/stackit/internal/core" | ||
|
||
"github.com/hashicorp/terraform-plugin-framework-timetypes/timetypes" | ||
"github.com/hashicorp/terraform-plugin-framework/datasource/schema" | ||
"github.com/stackitcloud/stackit-sdk-go/core/config" | ||
"github.com/stackitcloud/stackit-sdk-go/services/objectstorage" | ||
) | ||
|
||
// Ensure the implementation satisfies the expected interfaces. | ||
var ( | ||
_ datasource.DataSource = &credentialDataSource{} | ||
) | ||
|
||
// NewCredentialDataSource is a helper function to simplify the provider implementation. | ||
func NewCredentialDataSource() datasource.DataSource { | ||
return &credentialDataSource{} | ||
} | ||
|
||
// credentialDataSource is the resource implementation. | ||
type credentialDataSource struct { | ||
client *objectstorage.APIClient | ||
} | ||
|
||
// Metadata returns the resource type name. | ||
func (r *credentialDataSource) Metadata(_ context.Context, req datasource.MetadataRequest, resp *datasource.MetadataResponse) { | ||
resp.TypeName = req.ProviderTypeName + "_objectstorage_credential" | ||
} | ||
|
||
// Configure adds the provider configured client to the datasource. | ||
func (r *credentialDataSource) Configure(ctx context.Context, req datasource.ConfigureRequest, resp *datasource.ConfigureResponse) { | ||
// Prevent panic if the provider has not been configured. | ||
if req.ProviderData == nil { | ||
return | ||
} | ||
|
||
providerData, ok := req.ProviderData.(core.ProviderData) | ||
if !ok { | ||
core.LogAndAddError(ctx, &resp.Diagnostics, "Error configuring API client", fmt.Sprintf("Expected configure type stackit.ProviderData, got %T", req.ProviderData)) | ||
return | ||
} | ||
|
||
var apiClient *objectstorage.APIClient | ||
var err error | ||
if providerData.PostgreSQLCustomEndpoint != "" { | ||
apiClient, err = objectstorage.NewAPIClient( | ||
config.WithCustomAuth(providerData.RoundTripper), | ||
config.WithEndpoint(providerData.PostgreSQLCustomEndpoint), | ||
) | ||
} else { | ||
apiClient, err = objectstorage.NewAPIClient( | ||
config.WithCustomAuth(providerData.RoundTripper), | ||
config.WithRegion(providerData.Region), | ||
) | ||
} | ||
|
||
if err != nil { | ||
core.LogAndAddError(ctx, &resp.Diagnostics, "Error configuring API client", fmt.Sprintf("Configuring client: %v", err)) | ||
return | ||
} | ||
|
||
r.client = apiClient | ||
tflog.Info(ctx, "ObjectStorage credential client configured") | ||
} | ||
|
||
// Schema defines the schema for the datasource. | ||
func (r *credentialDataSource) Schema(_ context.Context, _ datasource.SchemaRequest, resp *datasource.SchemaResponse) { | ||
descriptions := map[string]string{ | ||
"main": "ObjectStorage credential data source schema.", | ||
"id": "Terraform's internal resource identifier. It is structured as \"`project_id`,`credentials_group_id`,`credential_id`\".", | ||
"credential_id": "The credential ID.", | ||
"credentials_group_id": "The credential group ID.", | ||
"project_id": "STACKIT Project ID to which the credential group is associated.", | ||
} | ||
|
||
resp.Schema = schema.Schema{ | ||
Description: descriptions["main"], | ||
Attributes: map[string]schema.Attribute{ | ||
"id": schema.StringAttribute{ | ||
Description: descriptions["id"], | ||
Computed: true, | ||
}, | ||
"credential_id": schema.StringAttribute{ | ||
Description: descriptions["credential_id"], | ||
Required: true, | ||
}, | ||
"credentials_group_id": schema.StringAttribute{ | ||
Description: descriptions["credentials_group_id"], | ||
Required: true, | ||
}, | ||
"project_id": schema.StringAttribute{ | ||
Description: descriptions["project_id"], | ||
Required: true, | ||
}, | ||
"name": schema.StringAttribute{ | ||
Computed: true, | ||
}, | ||
"access_key": schema.StringAttribute{ | ||
Computed: true, | ||
}, | ||
"secret_access_key": schema.StringAttribute{ | ||
Computed: true, | ||
Sensitive: true, | ||
}, | ||
"expiration_timestamp": schema.StringAttribute{ | ||
CustomType: timetypes.RFC3339Type{}, | ||
Required: true, | ||
}, | ||
}, | ||
} | ||
} | ||
|
||
// Read refreshes the Terraform state with the latest data. | ||
func (r *credentialDataSource) Read(ctx context.Context, req datasource.ReadRequest, resp *datasource.ReadResponse) { // nolint:gocritic // function signature required by Terraform | ||
var model Model | ||
diags := req.Config.Get(ctx, &model) | ||
resp.Diagnostics.Append(diags...) | ||
if resp.Diagnostics.HasError() { | ||
return | ||
} | ||
|
||
projectId := model.ProjectId.ValueString() | ||
credentialsGroupId := model.CredentialsGroupId.ValueString() | ||
credentialId := model.CredentialId.ValueString() | ||
ctx = tflog.SetField(ctx, "project_id", projectId) | ||
ctx = tflog.SetField(ctx, "credentials_group_id", credentialsGroupId) | ||
ctx = tflog.SetField(ctx, "credential_id", credentialId) | ||
|
||
err := readCredentials(ctx, &model, r.client) | ||
if err != nil { | ||
core.LogAndAddError(ctx, &resp.Diagnostics, "Error reading credential", fmt.Sprintf("Finding credential: %v", err)) | ||
return | ||
} | ||
|
||
// Set refreshed state | ||
diags = resp.State.Set(ctx, model) | ||
resp.Diagnostics.Append(diags...) | ||
if resp.Diagnostics.HasError() { | ||
return | ||
} | ||
tflog.Info(ctx, "ObjectStorage credential read") | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.