Skip to content

Object storage improvements #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 13, 2023
Merged

Object storage improvements #84

merged 6 commits into from
Oct 13, 2023

Conversation

hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Oct 13, 2023 •
edited
Loading

  • Add examples
  • Rename bucket's bucket_name --> name

@hcsa73 hcsa73 changed the title Hs/add object storage examples Object storage improvements Oct 13, 2023
joaopalet
joaopalet suggested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@joaopalet joaopalet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's missing the example for the credentials_group data source and re-generating the docs after the examples were added

@hcsa73
Copy link
Contributor Author

hcsa73 commented Oct 13, 2023

The example was already merged

@joaopalet
Copy link
Contributor

Ah I think the issue is that the example folder names need to reflect the name of the resource/data source.

Meaning it should be examples/…/stackit_objectstorage_…/ instead of examples/…/stackit_object_storage_…/

@hcsa73
Copy link
Contributor Author

hcsa73 commented Oct 13, 2023

Ah, it's the folder names that are wrong

@hcsa73 hcsa73 merged commit 6e51bdd into main Oct 13, 2023
@hcsa73 hcsa73 deleted the hs/add-object-storage-examples branch October 13, 2023 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joaopalet joaopalet joaopalet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcsa73 @joaopalet