Skip to content

Implement Secrets Manager User, change ACL to Set #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 19, 2023
Merged

Implement Secrets Manager User, change ACL to Set #94

merged 14 commits into from
Oct 19, 2023

Conversation

hcsa73
Copy link
Contributor

@hcsa73 hcsa73 commented Oct 19, 2023 •
edited
Loading

  • Implement User (Resource and data source)
  • Instance.ACL is now a Set instead of a List.
    • Was making acc tests fail due to order being important
    • Added acc test case for checking that duplicates are removed
  • Reorder resource/data source list

@hcsa73 hcsa73 changed the title Secrets Manager improvements Implement Secrets Manager User, change ACL to Set Oct 19, 2023
joaopalet
joaopalet approved these changes Oct 19, 2023
View reviewed changes
@hcsa73 hcsa73 merged commit 7a7f28a into main Oct 19, 2023
@hcsa73 hcsa73 deleted the hs/secrets-manager-user branch October 19, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@joaopalet joaopalet joaopalet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hcsa73 @joaopalet