Skip to content

Conversation

kristjanvalur
Copy link
Collaborator

@kristjanvalur kristjanvalur commented Jul 25, 2021

This pulls in two major changes:

  1. the stackman_call() API, as documented
  2. Github Actions for compiling and testing
    The chief changes involved using Github Actions to automate the building, testing and committing of build artifacts

@kristjanvalur kristjanvalur marked this pull request as ready for review July 25, 2021 18:02
@kristjanvalur kristjanvalur requested a review from akruis July 25, 2021 18:02
@kristjanvalur
Copy link
Collaborator Author

You will notice that the GHA now contains an automatic "commit" step that runs as well. This is convenient when working in a repo where the artifacts are commited as well, but we may want to think about better ways to do this, for example, by generating releases that explicitly cause the artifact libraries to be generated. also somehow add the libraries maybe to .gitignore or something so that they are not merged across along with source code changes. Not sure what is the best way to do this.

Copy link
Contributor

@akruis akruis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kristjanvalur
Copy link
Collaborator Author

I'll consult with a colleague to make suggestions wrt. Github actions and how to manage binaries.

@kristjanvalur kristjanvalur merged commit dbc72fe into stackless-dev:master Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants