This repository was archived by the owner on Jul 8, 2025. It is now read-only.
fix: handle breaking changes in frontend for "workspaces by provider" endpoint #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peppescg
approved these changes
Mar 6, 2025
Pull Request Test Coverage Report for Build 13694811223Details
💛 - Coveralls |
|
Superseded by #379 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stacklok/codegate#1233 I made a breaking change —
GET /api/v1/workspaces/:provider_idwas already in use for listing providers in use by a workspace, but now will return a full workspace by name. (GET /api/v1/workspaces/:provider_id).The old functionality can be achieved with
GET /api/v1/workspaces?provider_id={ID}now instead — this PR wires that up for the frontend.