Skip to content
This repository was archived by the owner on Jun 5, 2025. It is now read-only.

Update config to add singleton instance and add inference unit tests #105

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

ptelang
Copy link
Contributor

@ptelang ptelang commented Nov 27, 2024

No description provided.

@ptelang ptelang requested review from jhrozek and lukehinds November 27, 2024 15:28
@ptelang ptelang force-pushed the add-inference-tests branch 2 times, most recently from d22906c to fcaba3b Compare November 27, 2024 15:36
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I just left 2 questions inline, mostly for my education.

Copy link
Contributor

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not enough to stop the PR but we need to use the provider name in the URL:

@self.router.post(f"/{self.provider_route_name}/completion")

@ptelang ptelang force-pushed the add-inference-tests branch from fcaba3b to d3bae7c Compare November 27, 2024 16:44
@ptelang ptelang force-pushed the add-inference-tests branch from d3bae7c to 458deb8 Compare November 27, 2024 17:17
@ptelang
Copy link
Contributor Author

ptelang commented Nov 27, 2024

Not enough to stop the PR but we need to use the provider name in the URL:

@self.router.post(f"/{self.provider_route_name}/completion")

The provider name is added back in the URL.

@ptelang ptelang merged commit 909d9f1 into main Nov 27, 2024
2 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants