Error running workloads when otel endpoint set

[danbarr]

Bug description

Starting in v0.3.3, I cannot run any workloads while an OTel endpoint is set, either in the global config or with the run flag. The workload does not start, and the following error shows in the log file:

Error: failed to restart workload osv: failed to create middleware of type telemetry: failed to create telemetry provider: failed to build telemetry providers: service cannot be empty

Reverting to v0.3.2, it works as expected.

Steps to reproduce

Run an MCP server with an OTel endpoint (the endpoint doesn't actually have to be running to see the issue):

thv run osv --otel-endpoint localhost:4318 --otel-insecure

Then see that the server doesn't start, and the log contains an error:

thv list
tail ~/Library/Application\ Support/toolhive/logs/osv.log

12:58PM	WARN	Warning: Failed to find container: workload not found: no containers found (container: osv): failed to inspect workload: workload not found: no containers found (container: osv) (container: osv)
12:58PM	WARN	Trying to find state with name osv directly...
12:58PM	INFO	Loaded configuration from state for osv
12:58PM	INFO	Starting tooling server osv...
12:58PM	INFO	OIDC validation disabled, using local user authentication
12:58PM	INFO	Using local user authentication for user: dan
Error: failed to restart workload osv: failed to create middleware of type telemetry: failed to create telemetry provider: failed to build telemetry providers: service cannot be empty

Expected behavior

The workload should start with telemetry enabled.

Actual behavior

The workload fails to start and an error is logged.

Environment (if relevant)

• OS/version: macOS, Docker Desktop
• ToolHive version: v0.3.3

[ChrisJBurns]

It seems this is related to the fact that the ToolHive version is not being set. We should first fix that so the version is being set on release. We should then figure out why OTel does not work properly around the service check name when there is no version set for ToolHive.

[ChrisJBurns]

It seems that there was nothing wrong with OTel, it was erroring because the ServiceVersion cannot be "", otherwise it will throw a (vague) error - which is correct. Have raised #1968 to make the error logs a bit better.

[ChrisJBurns]

@danbarr we could probs close this?

[danbarr]

Yep, fixed in v0.3.5. Closing.