Skip to content

improves error logs for specific service name and version #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

improves error logs for specific service name and version #1968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/telemetry/providers/providers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ type ProviderOption func(*Config) error
func WithServiceName(serviceName string) ProviderOption {
return func(config *Config) error {
if serviceName == "" {
return fmt.Errorf("service cannot be empty")
return fmt.Errorf("service name cannot be empty")
}
config.ServiceName = serviceName
return nil
Expand All @@ -54,7 +54,7 @@ func WithServiceName(serviceName string) ProviderOption {
func WithServiceVersion(serviceVersion string) ProviderOption {
return func(config *Config) error {
if serviceVersion == "" {
return fmt.Errorf("service cannot be empty")
return fmt.Errorf("service version cannot be empty")
}
config.ServiceVersion = serviceVersion
return nil
Expand Down
Loading