Properly upgrade jsonschema library from v5 to v6 #2168
Merged
+21
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR properly handles the major version upgrade of the
github.com/santhosh-tekuri/jsonschema
library from v5 to v6.In Go, major version upgrades (v2+) require updating the import path to include the new version suffix. PR #2158 attempted this upgrade but only updated
go.mod
without updating the import paths and adapting to API changes, which caused compilation failures.Changes
jsonschema/v5
tojsonschema/v6
AddResource()
now accepts parsed JSON (any
) instead ofio.Reader
BasicOutput()
andOutputError.String()
methodsTesting
All tests pass successfully:
go test ./pkg/registry/...
✅task test
✅Migration Notes from v5 to v6
Key API changes in jsonschema v6:
AddResource()
signature changed from(url string, reader io.Reader)
to(url string, doc any)
ValidationError
structure changed - usesErrorKind
andBasicOutput()
instead ofMessage
fieldSee upstream migration discussion: santhosh-tekuri/jsonschema#172
Closes #2158
🤖 Generated with Claude Code