Skip to content

added fix for hanging loader absolute in windows #6 4d #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2025
Merged

added fix for hanging loader absolute in windows #6 4d #7

merged 3 commits into from
Feb 21, 2025

Conversation

diujin
Copy link
Contributor

@diujin diujin commented Feb 21, 2025

What is this PR for?

  • Just updating content and/or documentation
  • This fixes issue Loader Absolute hangs in windows. #6 _____
  • Spot fix (no issue #)
  • Merging WIP feature #_____
  • Merging done feature #_____
  • This is a merge from a version branch
  • Adding/Updating tests
  • This is a conflict resolution
  • This is a branch cleanup
  • Other: ________________

I verify that...

  • I have logged my time in the commits
  • I have logged my time in this PR
  • I have tagged all the relevant issues
  • I am using VS Code for type checks and linting, or
  • I have ran npm run test with no errors
  • I have manually checked that this bug or feature is working

cblanquera
cblanquera approved these changes Feb 21, 2025
View reviewed changes
Copy link
Contributor

@cblanquera cblanquera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The solution is acceptable, but please note the tabbing mistake on this commit. I'll fix it on the next commit.

@cblanquera cblanquera merged commit 637fe98 into stackpress:main Feb 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblanquera cblanquera cblanquera approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diujin @cblanquera