ROX-20232: Reduce duplication in Scanner Konflux pipelines #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
msugakov
force-pushed
the
misha/ROX-20232-sort-scanner-konflux-pipelines
branch
from
97224dc to
fad301b
Compare
msugakov
force-pushed
the
misha/ROX-20232-sort-scanner-konflux-pipelines
branch
from
fad301b to
927b9ef
Compare
Just pressed the magic keys combination, no manual changes.
These are redundant anyway.
the one isn't necessary.
So that factoring a common pipeline can go more easily.
Otherwise, they are used implicitly which does not look good.
with surroundings.
msugakov
force-pushed
the
misha/ROX-20232-sort-scanner-konflux-pipelines
branch
5 times, most recently
from
93c0feb to
a705ab2
Compare
msugakov
force-pushed
the
misha/ROX-20232-sort-scanner-konflux-pipelines
branch
8 times, most recently
from
374ba4a to
e24ae65
Compare
This allows not to fail scanner-db-slim build but at the same time have its pipeline definition identical to others.
and use it everywhere instead of repeating code.
It makes little sense to have `target-dir` anything outside workspaces, and there's only one workspace. Therefore, one can be relative. Also, given we save to repo root, I supplied the default. Not very sure but let's give it some time and see if it causes more maintenance.
msugakov
force-pushed
the
misha/ROX-20232-sort-scanner-konflux-pipelines
branch
from
5c2ab8b to
7a9f5d9
Compare
tommartensen
approved these changes
May 21, 2024
|
/retest |
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following example in stackrox/stackrox#10866, I factor a common pipeline that's reused for each scanner's component.
Testing: only CI.
EC seems to complain about outdated tasks, it's a known issue not caused by this.