-
Notifications
You must be signed in to change notification settings - Fork 15
ROX-30592: Adjust renovate config #2200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Split just the rename into #2201 |
No, I'll take it to draft to do https://issues.redhat.com/browse/ROX-30592 |
As part of https://issues.redhat.com/browse/ROX-30592 Note that I switched syntax from "Later" to "Cron" because that's what Renovate docs suggest. See https://docs.renovatebot.com/configuration-options/#schedule > Renovate supports the standard Cron syntax, as well as deprecated > support for a subset of Later syntax. We recommend you always use > Cron syntax, due to its superior testing and robustness. I checked the new expressions with https://crontab.guru
Our Cron expression for Konflux task updates plus the default limit of 2 may not allow creating all necessary PRs over the weekend. Therefore, I bump the value. Value `4` was unscientifically chosen. Found out about this setting from docs https://konflux-ci.dev/docs/mintmaker/user/#how-to-limit-the-number-of-prsmrs https://docs.renovatebot.com/configuration-options/#prhourlylimit
4f7b284
to
05c1bef
Compare
I changed my mind 360 degrees. The reason it was set to `false` is to prevent messing up the CI status due to MintMaker updates to PR. Let's keep it `false` and see how it goes.
@msugakov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Changes here:
Validation
Only ran the config validator. It complains about the unknown
rpm-lockfile
. Otherwise, it's ok.In general and as always, I don't know how it will work. Let's apply and see.