-
Notifications
You must be signed in to change notification settings - Fork 13
RS-322: Unify uninstall commands #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I recommend getting an approval from @RTann and/or @connorgorman before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When do we want to have this merged? I plan on cutting a new scanner release today, but if this needs to go into 67, then I will wait
This was answered on Slack. It is not a blocker for 67, so I will still cut the release today |
(dnf cannot be used after we remove it) This reverts commit 7444a44.
8f6a92a
to
a3bc8e5
Compare
* X-Smart-Branch-Parent: master * Unify uninstallation commands in Dockerfiles (keeping rpm)
This PR is a follow-up to the following tickets:
It unifies the command used to uninstall undesired packages from the Docker image.
The unified command was proposed as
rpm --verbose -e --nodeps $(rpm -qa curl '*rpm*' '*dnf*' '*libsolv*' '*hawkey*' 'yum*')
with exception forscanner
to not removerpm
.Additionally, it was discussed in Slack (link to the discussion in the ticket https://stack-rox.atlassian.net/browse/RS-322) that we should not remove
subscription-manager
as it cannot be used to install potentially malicious components.How tested
Diddocker build
anddocker run
afterwards and manually confirmed that package managers are removed butrpm
andsubscription-manager
kept.Unable to build this image locally
so I trust that CI would complain if, for example,
rpm
binary would be missing.