Update the CI build & test image to one based on centos:stream8 #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
gavin-stackrox
force-pushed
the
roxbot/update-ci-image-from-115
branch
from
65cc641 to
431ec11
Compare
gavin-stackrox
changed the title
gavin-stackrox
force-pushed
the
roxbot/update-ci-image-from-115
branch
from
874b0ac to
eb05135
Compare
RTann
approved these changes
Mar 9, 2022
| @@ -2,7 +2,7 @@ | |||
| version: 2.1 | |||
|
|
|||
| defaultImage: &defaultImage | |||
| image: "quay.io/rhacs-eng/apollo-ci:0.3.26" | |||
| image: "quay.io/rhacs-eng/apollo-ci:stackrox-test-cci-0.3.32" | |||
There was a problem hiding this comment.
Yes, more or less, there may be a stackrox-test-osci- at some point. Though I hope that can just be stackrox-test-. There is also a stackrox-build- just for building which will be used in openshift CI and is used in stackrox/stackrox make main-build-dockerized.
| @@ -31,9 +31,9 @@ main() { | |||
| mkdir -p "$log_dir" | |||
|
|
|||
| set +e | |||
| for pod in $(kubectl -n "${namespace}" get po | tail +2 | awk '{print $1}'); do | |||
| for pod in $(kubectl -n "${namespace}" get po | tail -n +2 | awk '{print $1}'); do | |||
There was a problem hiding this comment.
based on the manpage, my understanding is this will print all lines starting from line 2 (not 0-indexed)?
There was a problem hiding this comment.
right. in these cases it strips the column headings. in most cases in the 'code' tail -n +2 is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated PR created from stackrox/rox-ci-image#115.
This PR updates the CI build & test image to one based on
centos:stream8(wasubuntu).The only real change is that instances of
tail +2need to betail -n +2under centos.Testing performed: Ran 5x+ CI to ensure no introduced flakes.