fix(networkbaseline): Aggregate external flows in baseline status #15491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
Images are ready for the commit at 673344e. To use with deploy scripts, first |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15491 +/- ##
=======================================
Coverage 48.68% 48.69%
=======================================
Files 2602 2602
Lines 191486 191501 +15
=======================================
+ Hits 93234 93253 +19
+ Misses 90922 90918 -4
Partials 7330 7330
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Stringy
force-pushed
the
giles/fix-baseline-external-flows-aggregation
branch
2 times, most recently
from
5ed3a0f to
6233050
Compare
|
Caution There are some errors in your PipelineRun template.
|
To avoid complex behavior in the aggregation steps, the anonymization of discoverd external flows has been moved to its own component. This means that aggregation can aggregate by name/supernet/timestamp as normal and as a last step, the flows are transformed/anonymized before being added to the graph.
Stringy
force-pushed
the
giles/fix-baseline-external-flows-aggregation
branch
from
5720584 to
673344e
Compare
|
/test all |
Stringy
added a commit
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is a discrepancy between the flows shown on the network graph and the flows used by the network baseline API, where aggregation has not occurred and therefore it may report duplicate baseline results for a given deployment.
This PR applies the same aggregation method to the baseline API in order to match the graph view.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Test changes should be sufficient; otherwise manual testing on OCP cluster has confirmed that aggregation is successful and matches the network graph API