Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-15904: Remove migrated code #5361

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

Maddosaurus
Copy link
Member

@Maddosaurus Maddosaurus commented Mar 23, 2023

Description

As the caching scanner code was moved to Scanner in stackrox/scanner#1130, we can now remove it from Compliance.
As long as #5292 is not merged, the feature will not work without manual intervention, but Compliance will not crash and continue to function correctly.
The needed manual intervention would be to update the Collector DaemonSet to add the Node Scanning image to it.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

@Maddosaurus Maddosaurus requested a review from a team March 23, 2023 09:27
@Maddosaurus Maddosaurus enabled auto-merge (squash) March 23, 2023 09:29
@ghost
Copy link

ghost commented Mar 23, 2023

Images are ready for the commit at 2a13a7b.

To use with deploy scripts, first export MAIN_IMAGE_TAG=3.74.x-459-g2a13a7b3e0.

Copy link
Contributor

@jschnath jschnath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not much to review here

@Maddosaurus Maddosaurus merged commit 57b843a into master Mar 23, 2023
@Maddosaurus Maddosaurus deleted the mm/rox-15904-cache-scanner-migration branch March 23, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants