ROX-14398: Group Role permission with Access one #5848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
This was referenced Apr 28, 2023
3 tasks
|
Images are ready for the commit at 1b13aac. To use with deploy scripts, first |
rhybrillou
force-pushed
the
master-yann/ROX-14398-group_role_resource_with_access
branch
from
bdbbecd
to
a4ab803
Compare
rhybrillou
force-pushed
the
master-yann/ROX-14398-group_role_resource_with_access
branch
3 times, most recently
from
094b3dc
to
f06d40b
Compare
|
/retest |
rhybrillou
force-pushed
the
master-yann/ROX-14398-group_role_resource_with_access
branch
from
f06d40b
to
1b13aac
Compare
rhybrillou
deleted the
master-yann/ROX-14398-group_role_resource_with_access
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change is part of a series with the goal of making the configuration of user access control easier, and of limiting the risk of features not working because of missing permissions.
The goal is to bring the
Rolepermission under the umbrella of theAccessone.Checklist
- [ ] Unit test and regression tests added- [ ] Determined and documented upgrade steps- [ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)If any of these don't apply, please comment below.
Testing Performed
CI should be sufficient