Skip to content

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 10, 2025

Simple fix I noticed while answering a question.

@obycode obycode requested review from a team as code owners September 10, 2025 17:01
@obycode obycode added this to the 3.2.0.0.2 milestone Sep 10, 2025
jcnelson
jcnelson previously approved these changes Sep 11, 2025
Co-authored-by: Federico De Felici <fdf8210@gmail.com>
fdefelici
fdefelici previously approved these changes Sep 12, 2025
@github-project-automation github-project-automation bot moved this to Status: 💻 In Progress in Stacks Core Eng Sep 17, 2025
@kantai kantai added this pull request to the merge queue Sep 17, 2025
Merged via the queue into stacks-network:develop with commit 3271dad Sep 17, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Sep 17, 2025
Copy link

codecov bot commented Sep 17, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.53%. Comparing base (b1332a7) to head (9bc5be8).
⚠️ Report is 41 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/main.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #6452       +/-   ##
============================================
+ Coverage    66.44%   79.53%   +13.08%     
============================================
  Files          563      563               
  Lines       344904   344905        +1     
============================================
+ Hits        229167   274311    +45144     
+ Misses      115737    70594    -45143     
Files with missing lines Coverage Δ
stackslib/src/main.rs 0.00% <0.00%> (ø)

... and 331 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1332a7...9bc5be8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants