Skip to content

Conversation

Jiloc
Copy link
Contributor

@Jiloc Jiloc commented Sep 15, 2025

Description

While launching cargo clippy-stackslib locally I noticed that a warning popped up, and I realized that the command is not currently called by the CI, hence this PR!

This PR also updates the CONTRIBUTING.md with information about how to launch the command and fixes the warning.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@Jiloc Jiloc self-assigned this Sep 15, 2025
@Jiloc Jiloc marked this pull request as ready for review September 15, 2025 15:21
@Jiloc Jiloc requested review from a team as code owners September 15, 2025 15:21
@Jiloc Jiloc requested a review from wileyj September 15, 2025 15:21
@Jiloc Jiloc added the CI label Sep 15, 2025
@Jiloc Jiloc moved this to Status: In Review in Stacks Core Eng Sep 15, 2025
@Jiloc Jiloc added this to the 3.2.0.0.2 milestone Sep 15, 2025
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: 💻 In Progress in Stacks Core Eng Sep 17, 2025
@Jiloc Jiloc moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Sep 17, 2025
@wileyj wileyj added this pull request to the merge queue Sep 17, 2025
Merged via the queue into stacks-network:develop with commit eb0f852 Sep 17, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Sep 17, 2025
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Status: Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants