Skip to content

Conversation

jferrant
Copy link
Contributor

Closes #6460

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested review from a team as code owners September 17, 2025 19:15
@jferrant jferrant added aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change labels Sep 17, 2025
fdefelici
fdefelici previously approved these changes Sep 18, 2025
Jiloc
Jiloc previously approved these changes Sep 18, 2025
Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant dismissed stale reviews from Jiloc and fdefelici via 4774c6c September 18, 2025 17:22
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 83.26360% with 320 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.41%. Comparing base (5d37187) to head (88f4280).
⚠️ Report is 6 commits behind head on aac-client-breaking.

Files with missing lines Patch % Lines
clarity-types/src/errors/analysis.rs 66.42% 47 Missing ⚠️
...y/src/vm/analysis/type_checker/v2_1/natives/mod.rs 63.33% 33 Missing ⚠️
clarity-types/src/types/signatures.rs 72.89% 29 Missing ⚠️
clarity/src/vm/functions/assets.rs 50.94% 26 Missing ⚠️
.../src/vm/analysis/type_checker/v2_05/natives/mod.rs 59.61% 21 Missing ⚠️
clarity/src/vm/analysis/type_checker/v2_1/mod.rs 75.00% 18 Missing ⚠️
clarity/src/vm/functions/database.rs 73.52% 18 Missing ⚠️
clarity/src/vm/analysis/type_checker/v2_05/mod.rs 74.46% 12 Missing ⚠️
clarity/src/vm/functions/arithmetic.rs 28.57% 10 Missing ⚠️
clarity/src/vm/functions/options.rs 52.38% 10 Missing ⚠️
... and 28 more
Additional details and impacted files
@@                   Coverage Diff                    @@
##           aac-client-breaking    #6503       +/-   ##
========================================================
+ Coverage                69.17%   79.41%   +10.24%     
========================================================
  Files                      565      565               
  Lines                   346464   346594      +130     
========================================================
+ Hits                    239665   275257    +35592     
+ Misses                  106799    71337    -35462     
Files with missing lines Coverage Δ
clarity-types/src/errors/mod.rs 75.30% <100.00%> (ø)
clarity-types/src/representations.rs 85.49% <ø> (ø)
clarity-types/src/tests/types/mod.rs 96.86% <100.00%> (+13.93%) ⬆️
clarity-types/src/tests/types/serialization.rs 98.31% <100.00%> (+7.77%) ⬆️
clarity-types/src/tests/types/signatures.rs 99.57% <100.00%> (+99.57%) ⬆️
clarity/src/vm/analysis/arithmetic_checker/mod.rs 92.48% <ø> (ø)
clarity/src/vm/analysis/read_only_checker/tests.rs 100.00% <100.00%> (+53.79%) ⬆️
clarity/src/vm/analysis/trait_checker/mod.rs 100.00% <100.00%> (ø)
clarity/src/vm/analysis/trait_checker/tests.rs 85.42% <ø> (ø)
...ity/src/vm/analysis/type_checker/v2_05/contexts.rs 98.24% <100.00%> (ø)
... and 72 more

... and 215 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d37187...88f4280. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jferrant jferrant requested review from Jiloc and fdefelici September 18, 2025 19:47
Jiloc
Jiloc previously approved these changes Sep 19, 2025
Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

A conflict need to addressed

jcnelson
jcnelson previously approved these changes Sep 22, 2025
@jcnelson
Copy link
Member

LGTM; happy to re-review once the merge conflicts are addressed

@Jiloc Jiloc added this pull request to the merge queue Sep 23, 2025
Merged via the queue into stacks-network:aac-client-breaking with commit 927747c Sep 23, 2025
301 of 302 checks passed
Copy link

github-actions bot commented Oct 1, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Oct 1, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename and document clarity::vm::analysis::errors::CheckErrors to CheckErrorKind
4 participants