-
Notifications
You must be signed in to change notification settings - Fork 705
Chore/aac rename check errors #6503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/aac rename check errors #6503
Conversation
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## aac-client-breaking #6503 +/- ##
========================================================
+ Coverage 69.17% 79.41% +10.24%
========================================================
Files 565 565
Lines 346464 346594 +130
========================================================
+ Hits 239665 275257 +35592
+ Misses 106799 71337 -35462
... and 215 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
A conflict need to addressed
…rk/stacks-core into chore/aac-rename-check-errors
LGTM; happy to re-review once the merge conflicts are addressed |
…rk/stacks-core into chore/aac-rename-check-errors
927747c
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #6460