-
Notifications
You must be signed in to change notification settings - Fork 705
Chore/aac rename vm error #6508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/aac rename vm error #6508
Conversation
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
…nflicts with its rename Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Codecov Report❌ Patch coverage is ❌ Your project status has failed because the head coverage (73.66%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## aac-client-breaking #6508 +/- ##
=======================================================
- Coverage 79.88% 73.66% -6.23%
=======================================================
Files 565 565
Lines 346594 346611 +17
=======================================================
- Hits 276882 255335 -21547
- Misses 69712 91276 +21564
... and 219 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
A conflict need to addressed
…rk/stacks-core into chore/aac-rename-vm-error
Just need to address conflicts and I'll re-approve |
…rk/stacks-core into chore/aac-rename-vm-error
…rk/stacks-core into chore/aac-rename-vm-error
0c88f08
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Closes #6455