Skip to content

Conversation

jferrant
Copy link
Contributor

Closes #6455

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested review from a team as code owners September 17, 2025 23:08
@jferrant jferrant added aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change labels Sep 17, 2025
@jferrant jferrant linked an issue Sep 17, 2025 that may be closed by this pull request
fdefelici
fdefelici previously approved these changes Sep 18, 2025
…nflicts with its rename

Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
Signed-off-by: Jacinta Ferrant <jacinta.ferrant@gmail.com>
@jferrant jferrant requested review from Jiloc and fdefelici September 18, 2025 19:35
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 84.88372% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.66%. Comparing base (927747c) to head (1feb9b4).
⚠️ Report is 8 commits behind head on aac-client-breaking.

Files with missing lines Patch % Lines
clarity/src/vm/database/clarity_db.rs 16.66% 5 Missing ⚠️
clarity-types/src/errors/mod.rs 86.66% 4 Missing ⚠️
pox-locking/src/pox_3.rs 50.00% 4 Missing ⚠️
pox-locking/src/pox_4.rs 50.00% 4 Missing ⚠️
clarity-types/src/tests/types/mod.rs 84.21% 3 Missing ⚠️
pox-locking/src/lib.rs 40.00% 3 Missing ⚠️
pox-locking/src/pox_2.rs 62.50% 3 Missing ⚠️
stackslib/src/clarity_vm/tests/large_contract.rs 0.00% 3 Missing ⚠️
stackslib/src/chainstate/stacks/db/blocks.rs 80.00% 2 Missing ⚠️
clarity/src/vm/coverage.rs 0.00% 1 Missing ⚠️
... and 7 more

❌ Your project status has failed because the head coverage (73.66%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           aac-client-breaking    #6508      +/-   ##
=======================================================
- Coverage                79.88%   73.66%   -6.23%     
=======================================================
  Files                      565      565              
  Lines                   346594   346611      +17     
=======================================================
- Hits                    276882   255335   -21547     
- Misses                   69712    91276   +21564     
Files with missing lines Coverage Δ
clarity-types/src/lib.rs 100.00% <ø> (ø)
clarity-types/src/tests/types/serialization.rs 94.59% <100.00%> (-3.72%) ⬇️
clarity/src/vm/ast/mod.rs 82.43% <100.00%> (ø)
clarity/src/vm/callables.rs 96.32% <100.00%> (ø)
clarity/src/vm/clarity.rs 83.26% <100.00%> (ø)
clarity/src/vm/contexts.rs 91.61% <100.00%> (-0.09%) ⬇️
clarity/src/vm/costs/cost_functions.rs 100.00% <100.00%> (ø)
clarity/src/vm/costs/mod.rs 82.29% <ø> (-0.37%) ⬇️
clarity/src/vm/docs/contracts.rs 94.30% <100.00%> (ø)
clarity/src/vm/functions/assets.rs 85.43% <100.00%> (ø)
... and 44 more

... and 219 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927747c...1feb9b4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Jiloc
Jiloc previously approved these changes Sep 19, 2025
Copy link
Contributor

@Jiloc Jiloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fdefelici fdefelici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

A conflict need to addressed

jcnelson
jcnelson previously approved these changes Sep 22, 2025
@jcnelson
Copy link
Member

Just need to address conflicts and I'll re-approve

fdefelici
fdefelici previously approved these changes Sep 23, 2025
@Jiloc Jiloc added this pull request to the merge queue Sep 24, 2025
Merged via the queue into stacks-network:aac-client-breaking with commit 0c88f08 Sep 24, 2025
590 of 600 checks passed
Copy link

github-actions bot commented Oct 2, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Oct 2, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
aac Avoiding Accidental Consensus aac-api-breaking Avoiding accidental consensus api breaking change locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename and document clarity::vm::errors::Error to VmExecutionError
4 participants