Skip to content

Conversation

rdeioris
Copy link
Contributor

@rdeioris rdeioris commented Sep 18, 2025

Description

This patch allows simulation (read: rerunning) of one of the nakamoto blocks in the chain.
The goal is to retrieve an output with the content of the block that is not available in the chain (like events).

The simulation happens in the context of the Ephemeral MARF, so no data are written by the simulator.

The endpoint is authenticated.

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@rdeioris rdeioris marked this pull request as ready for review September 19, 2025 14:44
@rdeioris rdeioris requested review from a team as code owners September 19, 2025 14:44
@rdeioris rdeioris requested review from Jiloc and obycode September 19, 2025 14:44
@rdeioris rdeioris assigned kantai and rdeioris and unassigned kantai and rdeioris Sep 19, 2025
@rdeioris rdeioris requested a review from kantai September 19, 2025 14:45
obycode
obycode previously approved these changes Sep 23, 2025
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdeioris rdeioris added this pull request to the merge queue Sep 25, 2025
Merged via the queue into stacks-network:develop with commit 0e9fb5b Sep 25, 2025
297 of 301 checks passed
@rdeioris rdeioris deleted the feat/block_simulate_ephemeral_marf branch September 25, 2025 02:05
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 75.70621% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.96%. Comparing base (88058ef) to head (3a009b6).
⚠️ Report is 40 commits behind head on develop.

Files with missing lines Patch % Lines
stackslib/src/net/api/blockreplay.rs 83.46% 43 Missing ⚠️
stackslib/src/net/api/tests/blockreplay.rs 53.26% 43 Missing ⚠️

❌ Your project status has failed because the head coverage (70.96%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (88058ef) and HEAD (3a009b6). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (88058ef) HEAD (3a009b6)
145 114
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6511      +/-   ##
===========================================
- Coverage    80.36%   70.96%   -9.41%     
===========================================
  Files          565      567       +2     
  Lines       344860   345397     +537     
===========================================
- Hits        277142   245099   -32043     
- Misses       67718   100298   +32580     
Files with missing lines Coverage Δ
stackslib/src/net/api/mod.rs 93.15% <100.00%> (+0.19%) ⬆️
stackslib/src/net/api/tests/mod.rs 97.37% <ø> (-0.44%) ⬇️
stackslib/src/net/api/blockreplay.rs 83.46% <83.46%> (ø)
stackslib/src/net/api/tests/blockreplay.rs 53.26% <53.26%> (ø)

... and 301 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88058ef...3a009b6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

github-actions bot commented Oct 3, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot added the locked label Oct 3, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants