Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment step needs better failure logging #66

Closed
LindsayHill opened this issue Jan 25, 2019 · 1 comment
Closed

Deployment step needs better failure logging #66

LindsayHill opened this issue Jan 25, 2019 · 1 comment

Comments

@LindsayHill
Copy link
Contributor

When pushing changes to the index repo, the push step sometimes fails due to a race condition, or other situations such as invalid access token.

This causes the deployment step to exit, but the logs are unhelpful, because the code contains this:

git -C ~/index push origin 2>/dev/null

It would be helpful to have better logging here to identify the cause of the failure. (as well as fix the race condition, see #65)

@cognifloyd
Copy link
Member

Marking this as obsolete. When we identify future improvements, we should file new issues and specify which workflow to target (the pack test workflow, the index regen workflow, the pack bootstrap workflow, etc)

@cognifloyd cognifloyd closed this as not planned Won't fix, can't repro, duplicate, stale May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants