Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update stackframe to 1.x.x #28

Closed
wants to merge 22 commits into from
Closed

Update stackframe to 1.x.x #28

wants to merge 22 commits into from

Conversation

btd
Copy link

@btd btd commented Jan 5, 2016

No description provided.

ssenbud and others added 22 commits September 20, 2015 17:51
This removes parts of stack lines related to the eval lines and columns.
This was done this way to avoid breaking current stack traces until we
have a good solution for including them.
Motivation:
Focused specs, better ongoing support

Modifications:
Added jasmine and jasmine-core to package.json. Updated other
dependencies.
Function name in Error.stack can contain @ when function is defined as an
object property:

    const obj = { '@fn'() { throw new Error(); } };
    obj['@fn']();
    /*
    Exception: Error
    obj["@fn"]@Scratchpad/1:10:31
    @Scratchpad/1:11:1
    */
…n-name-with-at-sign

Fully parse function names with @ in Error.stack
@btd
Copy link
Author

btd commented Jan 8, 2016

Is anything there stopping from merge? Locally all tests passed.

@eriwen
Copy link
Member

eriwen commented Jan 8, 2016

Sorry for the delay here. This change may break downstream libraries because they cannot construct StackFrames the same way. It may be better to keep this off of master just until we're ready to implement parsing eval origins etc. for v2.0.

Do you have any urgent need for this change?

@btd
Copy link
Author

btd commented Jan 8, 2016

Not really urgent need, just to do not have in client bundle them twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants