Re-export StackFrame type for backwards compatibility #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
andersk
referenced
this pull request
Feb 12, 2022
The slight incompatibility of the old definition was necessitating unsafe casts between ErrorStackParser.StackFrame and StackFrame. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
|
Thanks for the PR @andersk! I'd like to prevent these kinds of regressions using automated checks. Do you have any recommendations (GitHub actions or npm scripts) to do this? |
RenateM
reviewed
Jun 7, 2022
There was a problem hiding this comment.
This commit seems to be causing our builds to fail with the following error:
ERROR in node_modules/error-stack-parser/error-stack-parser.d.ts:9:5 - error TS1128: Declaration or statement expected.
9 export type {StackFrame};
~~~~~~
node_modules/error-stack-parser/error-stack-parser.d.ts:9:17 - error TS1005: ';' expected.
9 export type {StackFrame};
~
|
@RenateM It sounds like you have a very old version of TypeScript. Make sure you’ve upgraded to at least 3.8 (latest: 4.7.3). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
2.0.7 removed a mis-matching export of
StackFrame(#54), but some users were relying on it. Re-export the correct one.Motivation and Context
#54 (comment)
How Has This Been Tested?
tsc error-stack-parser.d.tsTypes of changes
Checklist:
node_modules/.bin/jscs -c .jscsrc error-stack-parser.jspasses without errorsjscsin f5184d7.)npm testpasses without errors