Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Features/2 readme update #5

Merged
merged 3 commits into from
Dec 3, 2015
Merged

Features/2 readme update #5

merged 3 commits into from
Dec 3, 2015

Conversation

smudge202
Copy link
Contributor

I hope I haven't gone too far with the updates. I moved some of the links down to the bottom to make the file easier to read while editing, added the info mentioned regarding test automation, and merged with your generate step def's update.

I also made a minor amendment to the .sln as per David Fowler's recommendations and made the readme (and licence) available from with the solution under a docs virtual directory. Hopefully that's ok? Feel free to drop that change (or let me know and I'll revert the respective hunk).

@stajs
Copy link
Owner

stajs commented Dec 3, 2015

Cool, I'll merge your PR to get your doc updates (thanks!), but I'll back out these two things afterwards:

  1. It feels weird having to scroll to the bottom of the README and find the right link so I'll add them back in.
  2. I don't think that recommendation is from a Visual Studio solution point of view (e.g. you wouldn't include your .gitignore in your solution) so I'll revert the solution change.

Closes #2.

stajs added a commit that referenced this pull request Dec 3, 2015
@stajs stajs merged commit e6d4ae5 into stajs:master Dec 3, 2015
@smudge202 smudge202 deleted the features/2-readme-update branch December 3, 2015 22:24
@smudge202
Copy link
Contributor Author

I'll back those changes out as part of my next PR (incoming) if that's ok? (save on merge conflict).

@smudge202
Copy link
Contributor Author

I've just realised that the changes I made to the links totally didn't work in GFM! I see what you mean now; you shouldn't need to scroll to the bottom. I probably needed to add an additional line space between content and links or I've used tabs instead of spaces. GFM can be a little fickle.

@stajs
Copy link
Owner

stajs commented Dec 3, 2015

Sheeit, I just manually backed out those changes. Ah well, it shouldn't be too hard to merge your other PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants