-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
Note, I switched the version in the Also, it isn't necessary (or a particularly good idea) to have |
Sorry, looks like I did conflict you when manually backing out those changes 😞 Looks good (yes to |
I mean, once you've fixed the conflict (sorry). |
Sure. So, for reference, I did the following to test this local (incase it helps you). First, build the solution including the PR changes to produce output (or quickly replicate the change to In any solution that currently references
<?xml version="1.0" encoding="utf-8"?>
<configuration>
<packageSources>
<add key="local" value="D:\\\\Projects\\Resources\SpecFlow.Dnx\\src\\artifacts\\bin\\SpecFlow.Dnx\\Debug\\" />
<add key="api.nuget.org" value="https://api.nuget.org/v3/index.json" />
</packageSources>
</configuration>
The above sounds longwinded but in practice takes less than a minute to achieve and is very handy for testing packages pre-publication and without running a full private NuGet repo. Anyway, I'll see about these merge conflicts and takes yours for the most part. I can add a complete example to the samples directory if you want, but would it be easier to simply add the |
I've merged those changes, just sorting samples now. |
Good idea on the Hmm, regarding the samples... my original thoughts process was it would be better to have explicit examples per framework, but can be convinced otherwise if you think it's easier. |
I'll create a new PR for samples. The difficulty of course (without using aforementioned |
Gah, I'm suffering some problems with local testing against my consuming solution :/ I'm not sure I'm about to go incommunicado for a while, sorry, work calls and then weekend plans. I'll look to pick up in a couple of days (unless I can squeeze in some time in the weekend). |
Try out the samples PR. Should work and show it off for you? |
Okay, I've got a little bit of time before the weekend, I'll see if I can get this out. I'm on a different machine now and not experiencing the same problem that I had before when testing (whatever it was), so I'll assume it's all good and push out a new NuGet. (Feel like there should be a 💩 joke there...) I'll continue the discussion in the open issue/PR. |
Backed out some changes to ReadMe as per feedback on #5.
Backed out solution structure changes as per feedback on #5.
Switched TFM to
net40
to supportdnx451
as per #6. This gives us much a much wider compatibility than is required, but I don't believe that will be an issue.