Skip to content

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Apr 12, 2019

This PR removes the dependency on the 'arm' package, which was only being used internally for ppc_error_binned(). bayesplot now does the binning itself before plotting.

Copy link
Collaborator

@tjmahr tjmahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a visual unit test, the output of ppc_error_binned() before and after these changes has not changed. So I think we can merge this.

@tjmahr tjmahr merged commit 691cfea into master May 3, 2019
@tjmahr tjmahr deleted the remove-arm-dependency branch May 3, 2019 15:23
@jgabry
Copy link
Member Author

jgabry commented May 3, 2019

Great, thanks for adding that test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants