Skip to content

add facet_args to mcmc_rank_overlay #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2020
Merged

add facet_args to mcmc_rank_overlay #221

merged 1 commit into from
Jun 1, 2020

Conversation

hhau
Copy link
Contributor

@hhau hhau commented May 19, 2020

jgabry
jgabry approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@jgabry jgabry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@jgabry
Copy link
Member

jgabry commented Jun 1, 2020

I had to do a minor release to ensure compatibility with the release dplyr 1.0.0 but now that that's done, finally merging this. travis is failing but that seems to be due to rstan taking too long to install and not anything to do with this PR (everything passes for me locally).

Thanks again for the PR.

@jgabry jgabry merged commit 0c24254 into stan-dev:master Jun 1, 2020
@jgabry jgabry mentioned this pull request Jun 12, 2020
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgabry jgabry jgabry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hhau @jgabry