Skip to content

Conversation

jgabry
Copy link
Member

@jgabry jgabry commented Nov 10, 2022

* fix r cmd check issues from #282
* fix ggplot test issues (closes #289)
* add @TeemuSailynoja as contributor
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2022

Codecov Report

Attention: Patch coverage is 98.51485% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.53%. Comparing base (718b585) to head (10eac64).
Report is 125 commits behind head on master.

Files with missing lines Patch % Lines
R/zzz.R 33.33% 2 Missing ⚠️
R/mcmc-diagnostics.R 97.05% 1 Missing ⚠️
R/mcmc-distributions.R 93.33% 1 Missing ⚠️
R/ppc-loo.R 96.00% 1 Missing ⚠️
R/ppd-intervals.R 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #291      +/-   ##
==========================================
+ Coverage   97.72%   98.53%   +0.80%     
==========================================
  Files          35       35              
  Lines        4969     4972       +3     
==========================================
+ Hits         4856     4899      +43     
+ Misses        113       73      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgabry
Copy link
Member Author

jgabry commented Nov 12, 2022

CRAN wants a release by Nov 20th to fix the couple of failing tests due to the latest ggplot2 breaking changes.

I have a separate branch where I'm working on removing the use of deprecated features in ggplot2 (aes_ is deprecated) and tidyselect (.data for tidyselect is deprecated). If I have time to finish that in the next few days I'll incorporate that into this release).

@jgabry
Copy link
Member Author

jgabry commented Nov 12, 2022

CRAN wants a release by Nov 20th to fix the couple of failing tests due to the latest ggplot2 breaking changes.

I have a separate branch where I'm working on removing the use of deprecated features in ggplot2 (aes_ is deprecated) and tidyselect (.data for tidyselect is deprecated). If I have time to finish that in the next few days I'll incorporate that into this release).

#292 is now merged into this PR

@jgabry jgabry linked an issue Nov 13, 2022 that may be closed by this pull request
@jgabry jgabry linked an issue Nov 14, 2022 that may be closed by this pull request
@jgabry jgabry linked an issue Nov 15, 2022 that may be closed by this pull request
62 tasks
@jgabry
Copy link
Member Author

jgabry commented Nov 15, 2022

All checks are passing, so will merge and submit to CRAN!

@jgabry jgabry merged commit 717d851 into master Nov 15, 2022
@jgabry jgabry deleted the patch-for-cran branch November 15, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants