-
-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected pilots.stan and added script to find stan files without R sample #28
Conversation
As of Aug 4, 2015 ./Ch.10/sesame_one_pred_2b.stan ./Ch.10/sesame_one_pred_b.stan ./Ch.12/radon_group_chr.stan ./Ch.12/radon_intercept_chr.stan ./Ch.12/radon_no_pool_chr.stan ./Ch.13/13.4_UnderstandingCorrelationsBetweenIntercepts&Slopes.R ./Ch.13/earnings_latin_square_chr.stan ./Ch.13/earnings_vary_si_chr.stan ./Ch.13/pilots_chr.stan ./Ch.13/radon_inter_vary_chr.stan ./Ch.13/radon_vary_si_chr.stan ./Ch.14/pilots_chr.stan ./Ch.16/16.3_FittingAndUnderstangingAVaryingInterceptMultilevelModelUsingRStan.R ./Ch.17/17.2_radon_multi_varying_coef.stan ./Ch.17/17.5_multilevel_poisson.stan ./Ch.17/17.6_multilevel_ordered_categorical.stan ./Ch.17/17.7_latent_glm.stan ./Ch.17/17.7_robit.stan ./Ch.19/item_response.stan ./Ch.19/radon_chr.stan ./Ch.19/radon_redundant_chr.stan ./Ch.20/hiv_chr.stan ./Ch.20/hiv_inter_chr.stan ./Ch.21/finite_populations.stan ./Ch.21/multiple_comparison.stan ./Ch.21/r_sqr.stan ./Ch.21/radon_vary_intercept_floor.stan ./Ch.21/radon_vary_intercept_floor_chr.stan ./Ch.21/radon_vary_intercept_floor2_chr.stan ./Ch.21/radon_vary_intercept_nofloor_chr.stan ./Ch.22/anova_radon_nopred_chr.stan ./Ch.23/educational_subsidy.stan ./Ch.23/electric.stan ./Ch.23/electric_1a_chr.stan ./Ch.23/electric_1b_chr.stan ./Ch.23/electric_1c_chr.stan ./Ch.23/electric_chr.stan ./Ch.24/dogs_check.stan ./Ch.24/dogs_log.stan ./Ch.3/kidscore_momhs.stan ./Ch.4/earn_height.stan ./Ch.8/8.2_FakeDataSimulationToUnderstandResidualPlots.R
The suggested correction in http://stats.stackexchange.com/questions/143359/when-is-mu-a-used-in-this-stan-example is not correct. Changed variable names to those used in equation 13.9, i.e. gamma and delta instead of a and b. Removed unused mu_a and mu_b, and added common mu to really force gamma and delta into approx N(0,).
Add rats_stanified, with flat priors and avoiding sigma-squared detours. Print mean and stddev for all models, BUGS and Gelfand (original citation).
Thanks --- we'll review it soon and get it merged. Lots of us
|
Sorry for leaving the mess by working on the master branch. I had not planned to make a pull request from it, and git is only my third language. During my vacation, I try to improve my Stan by working on the BUGS examples. I plan to write R test programs, and, if possible, create a "stanified" version of the BUGS program. For example, by removing the inv-gamma priors and the sigma-squared contortions. https://github.com/dmenne/example-models/blob/master/bugs_examples/vol1/rats/rats.R What is the recommended workflow to make merging easier? Should I put every modified example in a separate branch? |
What we need is a pull request. I hope we're not duplicating work on the BUGS model You can see the whole development process here: https://github.com/stan-dev/stan/wiki The very first "Developer Process" wiki is what you want.
|
Corrected pilot examples to be close to ARM13.5
gamma
anddelta
instead of a and b.mu_a
andmu_b
,mu
to reallygamma
anddelta
into approxN(0,)
.