Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows integration tests. #2058

Closed
syclik opened this issue Sep 7, 2016 · 6 comments
Closed

Fix Windows integration tests. #2058

syclik opened this issue Sep 7, 2016 · 6 comments
Assignees

Comments

@syclik
Copy link
Member

syclik commented Sep 7, 2016

Summary:

Integration tests fail on Windows.

Description:

With the change to the integration tests trying to compile every model, we've now broken our Windows tests builds. It's trying to create executables that are too big for the linker using RTools's g++ 4.6.3.

I don't know if this problem no longer exists with a newer version of RTools.

The fix is to break apart the Stan programs into smaller chunks. There's a limit to the size of a Stan program and its different C++ instantiations under Windows. I don't think any user will realistically hit this limit unless they're generating code.

Reproducible Steps:

Run:

make src/test/test-models/good/function-signatures/distributions/univariate/continuous/exp_mod_normal/exp_mod_normal_ccdf_log_1.hpp-test

There are a few more that will fail. That's the first failure.

Current Output:

...
c:/rtools/gcc-4.6.3/bin/../lib/gcc/i686-w64-mingw32/4.6.3/../../../../i686-w64-mingw32/bin/as.exe: nul: too many sections (35710)
{standard input}: Assembler messages:
{standard input}: Fatal error: can't write nul: File too big

Expected Output:

It should just pass.

Additional Information:

Maybe our tests on Windows should just skip this?

Current Version:

v2.12.0

@syclik syclik added this to the v2.12.0++ milestone Sep 7, 2016
@syclik syclik self-assigned this Sep 7, 2016
@aadler
Copy link
Contributor

aadler commented Sep 7, 2016

Perhaps it's time to make rstan depend on R >= 3.3 and only use the 4.9.3 version of Rtools?

@syclik
Copy link
Member Author

syclik commented Sep 8, 2016

I'd prefer to have minimal requirements wherever possible. Here, we're just
pushing the ability of the 32-bit linker that comes with the compiler, I
think. If you look at what it's trying to do, it's not really realistic.
There's no need for us to force users to upgrade just to keep up with tests
that aren't even run by users.

On Wed, Sep 7, 2016 at 12:41 PM, Avraham Adler notifications@github.com
wrote:

Perhaps it's time to make rstan depend on R >= 3.3 and only use the 4.9.3
version of Rtools?


You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#2058 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_Fyn9K-uNhP0PfyIPWIFdFCB2tYCAks5qnuk6gaJpZM4J3AMe
.

@syclik syclik modified the milestones: v2.13.0, 2.13.0++ Oct 22, 2016
@syclik syclik modified the milestones: v2.13.1, v2.13.1++ Dec 3, 2016
@syclik syclik modified the milestones: v2.13.2, v2.13.2++ Dec 26, 2016
@bob-carpenter
Copy link
Contributor

@sycklik Is this still a problem? I added Sean as an asignee.

I'm also OK just skipping integration tests on Windows assuming we're doing it elsewhere if Windows can't handle it and this is going to be some hugely time-consuming process to fix. Otherwise, I'm just bumping to 2.15++ now until a decision can be made.

@bob-carpenter bob-carpenter modified the milestones: 2.15.0++, v2.14.0++ Mar 30, 2017
@syclik
Copy link
Member Author

syclik commented Mar 30, 2017 via email

@seantalts
Copy link
Member

Is it possible this will be fixed once we upgrade to the new R / Rcpp / RTools?

@syclik
Copy link
Member Author

syclik commented Apr 17, 2017 via email

@seantalts seantalts modified the milestones: 2.16.0, 2.17 Jul 5, 2017
@seantalts seantalts modified the milestones: 2.17.0, 2.17.0++ Sep 6, 2017
@seantalts seantalts modified the milestones: 2.18.0, 2.18.0++ Jul 13, 2018
@mitzimorris mitzimorris modified the milestones: 2.18.1, 2.18.1++ Dec 23, 2018
@seantalts seantalts modified the milestones: 2.18.1++, 2.19.0++ Mar 20, 2019
@mcol mcol removed this from the 2.22.0++ milestone Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants