-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows integration tests. #2058
Comments
Perhaps it's time to make rstan depend on R >= 3.3 and only use the 4.9.3 version of Rtools? |
I'd prefer to have minimal requirements wherever possible. Here, we're just On Wed, Sep 7, 2016 at 12:41 PM, Avraham Adler notifications@github.com
|
@sycklik Is this still a problem? I added Sean as an asignee. I'm also OK just skipping integration tests on Windows assuming we're doing it elsewhere if Windows can't handle it and this is going to be some hugely time-consuming process to fix. Otherwise, I'm just bumping to 2.15++ now until a decision can be made. |
Yes, this is still an outstanding issue. But I'm happy to give up on it for
now.
…On Thu, Mar 30, 2017 at 4:34 PM, Bob Carpenter ***@***.***> wrote:
@sycklik Is this still a problem? I added Sean as an asignee.
I'm also OK just skipping integration tests on Windows assuming we're
doing it elsewhere if Windows can't handle it and this is going to be some
hugely time-consuming process to fix. Otherwise, I'm just bumping to 2.15++
now until a decision can be made.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#2058 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAZ_F3ojp40-rPNq2CLkYIy_8RHl4Gz_ks5rrBHmgaJpZM4J3AMe>
.
|
Is it possible this will be fixed once we upgrade to the new R / Rcpp / RTools? |
Yes. It's very possible. I'm not too hopeful, but if it does, then great.
…On Mon, Apr 17, 2017 at 1:42 PM, seantalts ***@***.***> wrote:
Is it possible this will be fixed once we upgrade to the new R / Rcpp /
RTools?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#2058 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAZ_FzsPk9P0GaA5hRYzC2B9diYsnQs_ks5rw6R5gaJpZM4J3AMe>
.
|
Summary:
Integration tests fail on Windows.
Description:
With the change to the integration tests trying to compile every model, we've now broken our Windows tests builds. It's trying to create executables that are too big for the linker using RTools's g++ 4.6.3.
I don't know if this problem no longer exists with a newer version of RTools.
The fix is to break apart the Stan programs into smaller chunks. There's a limit to the size of a Stan program and its different C++ instantiations under Windows. I don't think any user will realistically hit this limit unless they're generating code.
Reproducible Steps:
Run:
There are a few more that will fail. That's the first failure.
Current Output:
Expected Output:
It should just pass.
Additional Information:
Maybe our tests on Windows should just skip this?
Current Version:
v2.12.0
The text was updated successfully, but these errors were encountered: