Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated function abs by fabs #1649

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Conversation

migueldvb
Copy link
Contributor

Replace abs by fabs in lasso example.

@stan-buildbot
Copy link
Contributor

Can one of the admins verify this patch?

@andrewgelman
Copy link
Collaborator

“fabs”???

On Oct 28, 2015, at 4:45 PM, Miguel de Val-Borro notifications@github.com wrote:

Replace abs by fabs in lasso example.

You can view, comment on, or merge this pull request online at:

#1649 #1649
Commit Summary

replace deprecated function abs by fabs
File Changes

M src/docs/stan-reference/advanced.tex https://github.com/stan-dev/stan/pull/1649/files#diff-0 (2)
Patch Links:

https://github.com/stan-dev/stan/pull/1649.patch https://github.com/stan-dev/stan/pull/1649.patch
https://github.com/stan-dev/stan/pull/1649.diff https://github.com/stan-dev/stan/pull/1649.diff

Reply to this email directly or view it on GitHub #1649.

@bob-carpenter
Copy link
Contributor

See the manual index for definitions and signatures
for abs() and fabs() and the corresponding min/max and fmin/fmax.

See old mail threads for discussion on why it's like that.

But before you tell us again that it doesn't have to be that way
and that it's "tacky", see:

https://github.com/stan-dev/stan/issues/1255

It's scheduled for Stan 3 because it's going to break backward
compatibility (unless we keep fabs and deprecate it).

This low-level maintenance coding never gets done because
nobody wants to do it.

  • Bob

On Oct 28, 2015, at 4:46 PM, Andrew Gelman notifications@github.com wrote:

“fabs”???

On Oct 28, 2015, at 4:45 PM, Miguel de Val-Borro notifications@github.com wrote:

Replace abs by fabs in lasso example.

You can view, comment on, or merge this pull request online at:

#1649 #1649
Commit Summary

replace deprecated function abs by fabs
File Changes

M src/docs/stan-reference/advanced.tex https://github.com/stan-dev/stan/pull/1649/files#diff-0 (2)
Patch Links:

https://github.com/stan-dev/stan/pull/1649.patch https://github.com/stan-dev/stan/pull/1649.patch
https://github.com/stan-dev/stan/pull/1649.diff https://github.com/stan-dev/stan/pull/1649.diff

Reply to this email directly or view it on GitHub #1649.


Reply to this email directly or view it on GitHub.

@andrewgelman
Copy link
Collaborator

That’s fine. If it’s in the manual, I can deal with it.
A

On Oct 28, 2015, at 5:09 PM, Bob Carpenter notifications@github.com wrote:

See the manual index for definitions and signatures
for abs() and fabs() and the corresponding min/max and fmin/fmax.

See old mail threads for discussion on why it's like that.

But before you tell us again that it doesn't have to be that way
and that it's "tacky", see:

https://github.com/stan-dev/stan/issues/1255

It's scheduled for Stan 3 because it's going to break backward
compatibility (unless we keep fabs and deprecate it).

This low-level maintenance coding never gets done because
nobody wants to do it.

  • Bob

On Oct 28, 2015, at 4:46 PM, Andrew Gelman notifications@github.com wrote:

“fabs”???

On Oct 28, 2015, at 4:45 PM, Miguel de Val-Borro notifications@github.com wrote:

Replace abs by fabs in lasso example.

You can view, comment on, or merge this pull request online at:

#1649 #1649
Commit Summary

replace deprecated function abs by fabs
File Changes

M src/docs/stan-reference/advanced.tex https://github.com/stan-dev/stan/pull/1649/files#diff-0 (2)
Patch Links:

https://github.com/stan-dev/stan/pull/1649.patch https://github.com/stan-dev/stan/pull/1649.patch
https://github.com/stan-dev/stan/pull/1649.diff https://github.com/stan-dev/stan/pull/1649.diff

Reply to this email directly or view it on GitHub #1649.


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub #1649 (comment).

@syclik
Copy link
Member

syclik commented Mar 2, 2016

This looks fine.

syclik added a commit that referenced this pull request Mar 2, 2016
replace deprecated function abs by fabs
@syclik syclik merged commit 181c624 into stan-dev:develop Mar 2, 2016
@syclik syclik added this to the v2.9.0++ milestone Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants