BREAKING: rename the syncronous lintText method to lintTextSync
#159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: standard/standard#807 - BREAKING: rename the syncronous `lintText` method to `lintTextSync` - Add an asyncronous `lintText` method (that just calls `lintTextSync` internally) This effectively undoes the breaking change introduced in 6.0.0, making it safe to upgrade from `standard-engine` 5.x to 7.x without introducing any breaking changes. Related: #156
|
Invited @bcomnes to the repo |
Flet
approved these changes
Apr 4, 2017
|
@Flet By the way, the context for this is that I want to upgrade from 5.x to 7.x in the |
|
@feross makes a ton of sense! Thanks! |
|
lgtm! |
This was referenced Apr 4, 2017
|
7.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: standard/standard#807
lintTextmethod tolintTextSynclintTextmethod (that just callslintTextSyncinternally)
This effectively undoes the breaking change introduced in 6.0.0, making it safe to upgrade from
standard-engine5.x to 7.x without introducing any breaking changes.But we also keep the new option to lint source text synchronously, just under a new
lintTextSync()method. This is better than overloadinglintTextto behave differently depending on whether a callback is passed in or not, IMO.Related: #156