-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect brackets in filename with the correct path #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, @feross! Thanks to this stackoverflow post : Windows ends lines with Since I added I simply quote the stackoverflow post : "If your team uses other OSs in addition to Windows: In this case you do want line endings to be normalized. To make it consistent for everyone, put |
What is the purpose of this pull request? (put an "X" next to item)
What changes did you make? (Give an overview)
newOptions.filename = file
with the correct path.For example :
[id].tsx
before the PR, the path was something like that%5Bid%5B.tsx
, now it is[id].tsx
as it is expected.It means custom parser like
@typescript-eslint/parser
used ints-standard
for example will not complain because the file does not match the project config.Thanks to @geospace report!
vsce
if theREADME.md
containimg
src tag withsvg
(should only bepng
orjpg
). Instead to use the cdn used in the https://github.com/standard/standard README, we use directly the logo in the root folder of this project with the GitHub link.tsc
compiles, we runnpm run package
instead of onlynpm run compile
in the Travis CI. It takes a liitle bit more time but it will not pass when for example we usesvg
instead ofpng
in README as it was the case in this PR Update README, LICENSE and CHANGELOG + add dependabot #136.1.4.1
section as pendingWhich issue (if any) does this pull request address?
#126
Is there anything you'd like reviewers to focus on?
Steps to reproduce the issue :
git clone https://github.com/standard/vscode-standardjs.git
git checkout fix/brackets-filename
npm install
npm run package
code --install-extension vscode-standardjs-1.4.0.vsix
ts-standard
andtypescript
asdevDependencies
and.vscode/settings.json
with this content :[id].tsx
with this content :Hopefully,
ts-standard
will show you lint errors cause of thesemicolon
, if it is the case It means the issue has been fixed!It's working for me as you can see on this screenshot :
If it's not working, feel free to send your file, with your
settings.json
and screenshots are always appreciated so we can investigate and try to fix this issue.