fix(MIPROv2): zero shot not taking .compile parameters into account before determining if the program was zero shot #8909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codex review |
TomeHirata
reviewed
Oct 7, 2025
| ) | ||
|
|
||
| # Update max demos if specified | ||
| initial_max_bootstrapped_demos = self.max_bootstrapped_demos |
There was a problem hiding this comment.
We should avoid updating instance attributes as much as possible. Can we update methods that rely on these attributes (e.g., _bootstrap_fewshot_examples) to receive them as arguments?
…efore determining if the program was zero shot
isaacbmiller
force-pushed
the
isaac/mipro-few-shot-bug
branch
from
9e6d5df to
2e898bc
Compare
|
Needs testing DNM |
|
@isaacbmiller feel free to merge once you run MIPRO with this code to confirm no regression! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
zeroshot_optoption, which determines if the proposer should use demos or not, was being set before applying the compile time arguments passed into the.compile functionFixes #8508