Windows Training #1514
Merged
Windows Training #1514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e when --save_output is not set. Avoiding tempfiles makes the script work on Windows Addresses the MWT part of stanfordnlp/stanza-train#20
…and other models look for wordvec_args as well) prepare_depparse also uses the POS wordvec args when retagging the depparse files build_depparse_wordvec_args instead of reusing the pos version
…a-train#20 Don't need to create a tempfile for POS
…s chosen. Addresses the lemmatizer portion of stanfordnlp/stanza-train#20
…since they now do the testing in memory when not saving output. stanfordnlp/stanza-train#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address using the same tempfile multiple times, which causes an error on Windows for not being able to reopen the same file twice. Fixes stanfordnlp/stanza-train#20