Skip to content

refactor: move some pydantic models around #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

refactor: move some pydantic models around #51

merged 3 commits into from
Apr 2, 2025

Conversation

gadomski
Copy link
Member

@gadomski gadomski commented Apr 2, 2025 •
edited
Loading

What I'm changing

  • Move some more pydantic models down into stapi-pydantic
  • Move conformance uris back up into stapi-fastapi
  • Change all stapi_pydantic imports to take directly from the top-level (simpler, IMO)

Checklist

  • Tests pass: uv run pytest
  • Checks pass: uv run pre-commit --all-files
  • CHANGELOG is updated (if necessary)

@gadomski gadomski requested review from j-tr and toro-berlin April 2, 2025 09:43
@gadomski gadomski self-assigned this Apr 2, 2025
@gadomski gadomski linked an issue Apr 2, 2025 that may be closed by this pull request
Move root model down to stapi-pydantic #50
Closed
j-tr
j-tr reviewed Apr 2, 2025
View reviewed changes
@gadomski gadomski requested a review from j-tr April 2, 2025 11:04
@gadomski gadomski merged commit f9f1816 into main Apr 2, 2025
3 checks passed
@gadomski gadomski deleted the issues/50-move-root branch April 2, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-tr j-tr j-tr approved these changes

@toro-berlin toro-berlin Awaiting requested review from toro-berlin

Assignees

@gadomski gadomski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move root model down to stapi-pydantic
2 participants
@gadomski @j-tr