Skip to content

Fee mechanism refactor #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

Conversation

LandauRaz
Copy link
Collaborator

@LandauRaz LandauRaz commented Feb 11, 2025

Description of the Changes

Refactored "Fee mechanism".

PR Preview URL

https://starknet-io.github.io/starknet-docs/pr-1520/architecture-and-concepts/network-architecture/fee-mechanism/

Check List

  • Changes made against main branch and PR does not conflict
  • PR title is meaningful, e.g: minor typos fix in README
  • Detailed description added under "Description of the Changes"
  • Specific URL(s) added under "PR Preview URL"

This change is Reviewable

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1520/ .

@LandauRaz LandauRaz changed the title Razl/update fee with sierra gas Fee mechanism refactor Feb 11, 2025
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1520/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1520/ .

@ArielElp ArielElp changed the base branch from main to v0.13.4 February 12, 2025 11:18
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1520/ .

@starknet-bot
Copy link
Collaborator

Oops, your pull request failed to pass the Typo tests stage :( . see the result:
error: assosiated should be associated
--> ./components/Starknet/modules/architecture-and-concepts/pages/network-architecture/fee-mechanism.adoc:161:276
|
161 | Tracking the execution trace length associated with each transaction is simple, as each assertion over field elements, such as verifying addition/multiplication over the field, requires the same constant number of trace cells. Therefore, in a world without builtins, the fee assosiated with the L2 computation component of a transaction stem:[$tx$] should be correlated with stem:[$\text{TraceCells}[tx]/L$].
| ^^^^^^^^^^
|

Please fix the typo, commit and push!

@starknet-bot
Copy link
Collaborator

Oops, your pull request failed to pass the Typo tests stage :( . see the result:
error: cosidered should be considered
--> ./components/Starknet/modules/architecture-and-concepts/pages/network-architecture/fee-mechanism.adoc:269:157
|
269 | - For VM resources only the maximal resource (e.g., most used builtin) is considered, while for Sierra gas the sum of all resources (i.e., all libfuncs) is cosidered
| ^^^^^^^^^
|

Please fix the typo, commit and push!

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1520/ .

@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1520/ .

1 similar comment
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1520/ .

Base automatically changed from v0.13.4 to main February 26, 2025 14:49
@LandauRaz LandauRaz mentioned this pull request Mar 5, 2025
4 tasks
@LandauRaz
Copy link
Collaborator Author

Replaced by #1544.

@LandauRaz LandauRaz closed this Mar 5, 2025
@LandauRaz LandauRaz deleted the razl/update_fee_with_sierra_gas branch March 21, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants