Add QM31 Lambdaworks wrapper #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
JulianGCalderon
changed the title
JulianGCalderon
requested review from
pefontana,
dan-starkware and
gabrielbosio
as code owners
tdelabro
requested changes
Sep 1, 2025
tdelabro
approved these changes
Sep 1, 2025
0xLucqs
approved these changes
Sep 4, 2025
gabrielbosio
added a commit
that referenced
this pull request
Sep 18, 2025
This reverts commit 2ede7b7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the QM31 newtype, as a wrapper of Lambdawork's type.
As the actual implementation is from Lambdaworks, I only needed to implement manually the
pack_into_feltandunpack_from_feltmethods.I also implemented wrappers for some common operations (add, mul, sub, div, inv, zero, one). Let me know if you prefer to add anything else.
Pull Request type
What is the current behavior?
We have no implementation of QM31
What is the new behavior?
Implements QM31 as a newtype of Lambdawork's type.
Does this introduce a breaking change?
No