Remove field macros #585
Closed
Remove field macros #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @spapinistarkware and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #585 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 67 67
Lines 8426 8435 +9
Branches 8426 8435 +9
=======================================
+ Hits 7913 7922 +9
Misses 449 449
Partials 64 64 ☔ View full report in Codecov by Sentry. |
Closed
spapinistarkware
force-pushed
the
spapini/04-24-remove_field_macros
branch
from
5b0ecc9
to
41de2e8
Compare
alonh5
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Reviewed 9 of 18 files at r1, 10 of 10 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @shaharsamocha7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is