Separate verifier crate

[spapinistarkware]

This change is 

[spapinistarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• Separate verifier crate #586 👈
• Remove field macros #585
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @spapinistarkware and the rest of your teammates on Graphite

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (41de2e8) to head (fffecde).

Additional details and impacted files

@@                          Coverage Diff                          @@
##           spapini/04-24-remove_field_macros     #586      +/-   ##
=====================================================================
+ Coverage                              93.91%   93.96%   +0.04%     
=====================================================================
  Files                                     67       67              
  Lines                                   8435     8435              
  Branches                                8435     8435              
=====================================================================
+ Hits                                    7922     7926       +4     
+ Misses                                   449      445       -4     
  Partials                                  64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[shaharsamocha7]

Reviewed 79 of 80 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/src/core/backend/avx512/circle.rs line 329 at r2 (raw file):

        a.swap_with_slice(&mut c[0..n0]);
    }
    fold(poly.coeffs.as_slice(), &mappings)

Why did you change it?

Code quote:

poly.coeffs.as_slice()

---

crates/verifier/Cargo.toml line 15 at r2 (raw file):

rand = { version = "0.8.5", features = ["small_rng"] }
[lib]
bench = false

Is this needed?

Code quote:

[lib]
bench = false

---

crates/verifier/Cargo.toml line 25 at r2 (raw file):

[features]
avx512 = []

Remove

Code quote:

[features]
avx512 = []

---

crates/verifier/src/core/fields/cm31.rs line 63 at r2 (raw file):

}

#[cfg(test)]

Can you keep it? Those functions were suppose to use us only for tests.
Same for the others.

Code quote:

#[cfg(test)]

---

crates/verifier/src/core/fields/mod.rs line 35 at r2 (raw file):

}

pub trait MulGroup: Mul<Output = Self> + MulAssign + Sized + One + Copy {

Can you add short documentation?

Suggestion:

/// Trait for performing field multiplicative group operations.
pub trait MulGroup: Mul<Output = Self> + MulAssign + Sized + One + Copy {

[spapinistarkware]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @shaharsamocha7)

---

crates/verifier/src/core/fields/cm31.rs line 63 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Can you keep it? Those functions were suppose to use us only for tests.
Same for the others.

One crate cannot access the test config items of another crate.

[shaharsamocha7]

Reviewable status: all files reviewed, 5 unresolved discussions (waiting on @spapinistarkware)

---

crates/verifier/src/core/fields/cm31.rs line 63 at r2 (raw file):

Previously, spapinistarkware (Shahar Papini) wrote…

One crate cannot access the test config items of another crate.

Ok.
Can you just confirm with AlonH if there was other reason why it is only for tests?
(unblocking)

[spapinistarkware]

Reviewable status: 78 of 80 files reviewed, 3 unresolved discussions (waiting on @shaharsamocha7)

---

crates/prover/src/core/backend/avx512/circle.rs line 329 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Why did you change it?

It was reimplementing this funcationality, whic is a bit silly.

---

crates/verifier/Cargo.toml line 25 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Remove

Done.

---

crates/verifier/src/core/fields/mod.rs line 35 at r2 (raw file):

Previously, shaharsamocha7 wrote…

Can you add short documentation?

Done.

[shaharsamocha7]

Reviewed 9 of 33 files at r4.
Reviewable status: 61 of 87 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

---

crates/prover/src/core/backend/mod.rs line 56 at r4 (raw file):

    // TODO(Ohad): change to use a mutable slice.
    fn batch_inverse(column: &Self::Column, dst: &mut Self::Column);
}

Can we use here the same pattern as in FriOps?

Code quote:

pub trait FieldOps<F: Field>: ColumnOps<F> {
    // TODO(Ohad): change to use a mutable slice.
    fn batch_inverse(column: &Self::Column, dst: &mut Self::Column);
}

[shaharsamocha7]

Reviewable status: 61 of 87 files reviewed, 1 unresolved discussion (waiting on @spapinistarkware)

[andrewmilson]

Reviewed 51 of 80 files at r1, 1 of 2 files at r2, 2 of 2 files at r3, 33 of 33 files at r4, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @spapinistarkware)

---

crates/prover/benches/eval_at_point.rs line 11 at r4 (raw file):

    use stwo_prover::core::poly::circle::{CanonicCoset, CircleEvaluation, PolyOps};
    use stwo_prover::core::poly::NaturalOrder;
    use stwo_verifier::core::fields::m31::BaseField;

I think it makes more sense to have a seperate stwo_fields crate. Seems strange importing fields from the verifier.

---

crates/prover/src/core/backend/avx512/circle.rs line 88 at r4 (raw file):

    fn twiddle_steps<F: Field>(mappings: &[F]) -> Vec<F>
    where
        F: MulGroup,

Nit:

Suggestion:

    fn twiddle_steps<F: Field + MulGroup>(mappings: &[F]) -> Vec<F>